[Access] Enable Event streaming on REST API

[UlyanaAndrukhiv]

#4379

This pull request:

• added a new route type wsroute with SubscribeEvents and its handler implementation to existing REST router,
• added new WSHandler to handle websockets requests,
• refactored REST Handler by moving common logic to HttpHandler,
• added unit and integration tests

[peterargue]

overall this approach looks good. I added a few comments, but didn't review thoroughly since this is still a work in progress.

[peterargue]

thanks for the updates! Added a few more, mostly nits and testing requests.

I tried to test this out using localnet and this curl command:

curl -vvv --include \
     --no-buffer \
     --header "Connection: Upgrade" \
     --header "Upgrade: websocket" \
     --header "Sec-WebSocket-Key: SGVsbG8sIHdvcmxkIQ==" \
     --header "Sec-WebSocket-Version: 13" \
     http://localhost:4004/v1/subscribe_events

it seems to timeout after a few seconds. I modified the code a bit to return errors from the read handler, and it returned

�>�read tcp 192.168.80.10:8070->192.168.80.1:37030: i/o timeout* Connection #0 to host localhost left intact

I suspect this is from the pong handler config.

[UlyanaAndrukhiv]

thanks for the updates! Added a few more, mostly nits and testing requests.

I tried to test this out using localnet and this curl command:

curl -vvv --include \
     --no-buffer \
     --header "Connection: Upgrade" \
     --header "Upgrade: websocket" \
     --header "Sec-WebSocket-Key: SGVsbG8sIHdvcmxkIQ==" \
     --header "Sec-WebSocket-Version: 13" \
     http://localhost:4004/v1/subscribe_events

it seems to timeout after a few seconds. I modified the code a bit to return errors from the read handler, and it returned

�>�read tcp 192.168.80.10:8070->192.168.80.1:37030: i/o timeout* Connection #0 to host localhost left intact

I suspect this is from the pong handler config.

Thank you for all your comments!

The timeout issue you encountered related to the WebSocket ping-pong mechanism. Curl is not well-suited for WebSocket testing as it does not handle WebSocket ping-pong processes. I tried using curl with the Gorilla WebSocket 'chat' example and received the same Connection #0 to host localhost left intact message.

I recommend wscat tool, which I have been using to test event streaming on localnet.

[durkmurder]

Looks good from my side, good job.

[peterargue]

Looking good. I think this is ready after these last few comments.

[peterargue]

looks good. Great work @UlyanaAndrukhiv!