Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Fix CCF decoding in GetTransactionResultsByBlockID #4532

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

peterargue
Copy link
Contributor

@peterargue peterargue commented Jun 28, 2023

These were fixed in v0.31 here:
#4462
#4465

Context

Execution nodes now use CCF encoding for events returned from their grpc API. They include a new version parameter to specify which encoding was used for the returned events. For GetTransactionResultsByBlockID, the encoding is returned in the top level GetTransactionResultsResponse message, not in each of the included GetTransactionResultResponse messages.

There was a bug on the Access node where it attempted to get the encoding from each GetTransactionResultResponse. When not specified, the default value is json-cdc, so the payload was not converted.

Note: not including the change to write the encoding version for every results on the EN side. That's unnecessary

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #4532 (1f5ef24) into master (2d46c07) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4532      +/-   ##
==========================================
- Coverage   51.85%   51.72%   -0.14%     
==========================================
  Files         635      726      +91     
  Lines       59308    65570    +6262     
==========================================
+ Hits        30757    33919    +3162     
- Misses      26101    29042    +2941     
- Partials     2450     2609     +159     
Flag Coverage Δ
unittests 51.72% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 92 files with indirect coverage changes

@zhangchiqing zhangchiqing merged commit 54f0f00 into master Jun 28, 2023
@zhangchiqing zhangchiqing deleted the petera/backport-get-results-by-block-ccf-fix branch June 28, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants