[Access] Fix CCF decoding in GetTransactionResultsByBlockID #4532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were fixed in v0.31 here:
#4462
#4465
Context
Execution nodes now use CCF encoding for events returned from their grpc API. They include a new version parameter to specify which encoding was used for the returned events. For
GetTransactionResultsByBlockID
, the encoding is returned in the top levelGetTransactionResultsResponse
message, not in each of the includedGetTransactionResultResponse
messages.There was a bug on the Access node where it attempted to get the encoding from each
GetTransactionResultResponse
. When not specified, the default value is json-cdc, so the payload was not converted.Note: not including the change to write the encoding version for every results on the EN side. That's unnecessary