Skip to content

Conversation

@turbolent
Copy link
Member

@turbolent turbolent commented Jun 7, 2023

Port of #4438 to v0.31

@turbolent turbolent requested review from a team June 7, 2023 18:54
@turbolent turbolent self-assigned this Jun 7, 2023
@turbolent turbolent requested review from gomisha and thep2p as code owners June 7, 2023 18:54
@turbolent
Copy link
Member Author

bors merge

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

FVM Benchstat comparison

This branch with compared with the base branch onflow:v0.31 commit 6435fb6

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #4439 (934d5d9) into v0.31 (e12a8a2) will increase coverage by 5.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            v0.31    #4439      +/-   ##
==========================================
+ Coverage   53.65%   59.15%   +5.50%     
==========================================
  Files         887      421     -466     
  Lines       82528    37065   -45463     
==========================================
- Hits        44283    21927   -22356     
+ Misses      34758    13399   -21359     
+ Partials     3487     1739    -1748     
Flag Coverage Δ
unittests 59.15% <ø> (+5.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 474 files with indirect coverage changes

@bors bors bot merged commit d988ba2 into v0.31 Jun 7, 2023
@bors bors bot deleted the bastian/v0.31-cadence-v0.39.3 branch June 7, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants