[Access] Added collection_id and block_id to GetTransactionResult arguments

[Guitarheroua]

#2099

Context

This pull request adds two new optional arguments to GetTransactionResult: collection_id and block_id. These arguments will help avoid duplicate transaction hashes. If both arguments are missing, the default lookup by transaction ID is performed. The block ID lookup has the highest priority, followed by the collection ID lookup if they are passed. This change ensures backward compatibility with previous versions of the code.

As part of this PR:

The protobuf and Open API were extended(onflow/flow#1335)

[peterargue]

Thanks @Guitarheroua! It could use some more input validation but it's pretty close.

[peterargue]

Thanks for making those changes. A few more comments, but it's very close.

[peterargue]

don't forget to update back to onflow/flow

[peterargue]

Looks good once the conflicts are addressed and the imports is switched back to onflow/flow

[koko1123]

looks good to me! aside from the dependency change in go.mod

[Guitarheroua]

looks good to me! aside from the dependency change in go.mod

@peterargue @koko1123 This one will be blocked if 1335 will not be reviewed. I do not know who is responsible for this repo to review.

[peterargue]

looks good to me! aside from the dependency change in go.mod

@peterargue @koko1123 This one will be blocked if 1335 will not be reviewed. I do not know who is responsible for this repo to review.

ah, sorry. I missed that one. Just approved. I'll work on getting it merged

[peterargue]

@Guitarheroua the protobuf changes were just merged

[codecov-commenter]

Codecov Report

Merging #4263 (1d6bce2) into master (3e35791) will decrease coverage by 10.37%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4263       +/-   ##
===========================================
- Coverage   53.66%   43.30%   -10.37%     
===========================================
  Files         860       14      -846     
  Lines       80029      709    -79320     
===========================================
- Hits        42950      307    -42643     
+ Misses      33684      359    -33325     
+ Partials     3395       43     -3352     

Flag	Coverage Δ
unittests	43.30% <ø> (-10.37%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 846 files with indirect coverage changes

[Guitarheroua]

bors merge

[bors]

🔒 Permission denied

Existing reviewers: click here to make Guitarheroua a reviewer

[durkmurder]

bors merge

[bors]

Build succeeded:

• Integration Tests (make -C integration access-tests)
• Integration Tests (make -C integration bft-tests)
• Integration Tests (make -C integration collection-tests)
• Integration Tests (make -C integration consensus-tests)
• Integration Tests (make -C integration epochs-tests)
• Integration Tests (make -C integration execution-tests)
• Integration Tests (make -C integration ghost-tests)
• Integration Tests (make -C integration mvp-tests)
• Integration Tests (make -C integration network-tests)
• Integration Tests (make -C integration verification-tests)
• Lint (./)
• Lint (./crypto/)
• Lint (./integration/)
• Unit Tests (access)
• Unit Tests (admin)
• Unit Tests (cmd)
• Unit Tests (consensus)
• Unit Tests (engine)
• Unit Tests (fvm)
• Unit Tests (ledger)
• Unit Tests (module)
• Unit Tests (network)
• Unit Tests (others)
• Unit Tests (utils)