Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read leaf nodes #4212

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Fix read leaf nodes #4212

merged 1 commit into from
Apr 13, 2023

Conversation

zhangchiqing
Copy link
Member

Backporting changes from this PR to master
#4137

fix error handling

refactor error handling
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #4212 (ea88fef) into master (55f5744) will decrease coverage by 10.43%.
The diff coverage is 68.75%.

@@             Coverage Diff             @@
##           master    #4212       +/-   ##
===========================================
- Coverage   61.74%   51.32%   -10.43%     
===========================================
  Files         168      681      +513     
  Lines       18276    60972    +42696     
===========================================
+ Hits        11285    31294    +20009     
- Misses       6115    27168    +21053     
- Partials      876     2510     +1634     
Flag Coverage Δ
unittests 51.32% <68.75%> (-10.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ledger/complete/wal/checkpoint_v6_leaf_reader.go 72.72% <68.75%> (ø)

... and 848 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zhangchiqing zhangchiqing merged commit 02932e0 into master Apr 13, 2023
@zhangchiqing zhangchiqing deleted the leo/fix-read-leaf-nodes branch April 13, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants