Improve transaction verifier clarity #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 3745401 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SaveTheRbtz
approved these changes
Jan 4, 2023
zhangchiqing
approved these changes
Jan 4, 2023
janezpodhostnik
approved these changes
Jan 5, 2023
fvm/transactionVerifier.go
Outdated
| // verifyAccountSignatures() is always called after getAccountKeys() | ||
| // (i.e., accountKey is always initialized by the time | ||
| // verifyAccountSignatures is called). | ||
| verified bool |
There was a problem hiding this comment.
verified=true reads as "signature was successfully verified" to me. Which is not what this is for. This is more like: "this signature already went through the verification step". Maybe a name like verificationDone would make that clearer.
There was a problem hiding this comment.
good point. i'll update the name
As per Leo's suggestions. Co-authored-by: Leo Zhang (zhangchiqing) <zhangchiqing@gmail.com>
pattyshack
force-pushed
the
patrick/leos-comments
branch
from
387bf21
to
d410289
Compare
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Leo's suggestions.
Co-authored-by: Leo Zhang (zhangchiqing) zhangchiqing@gmail.com