-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Benchmark] Prevent PID windup at start #3759
Conversation
a441541
to
862d3f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #3759 +/- ##
==========================================
- Coverage 55.37% 48.17% -7.20%
==========================================
Files 769 398 -371
Lines 70251 33934 -36317
==========================================
- Hits 38902 16348 -22554
+ Misses 28161 16256 -11905
+ Partials 3188 1330 -1858
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -76,6 +77,14 @@ func NewTPSAdjuster( | |||
go func() { | |||
defer close(a.done) | |||
|
|||
log.Info().Dur("delayInMS", params.Delay).Msg("Waiting before starting TPS adjuster") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea to inform the user there's going to be a delay.
bors merge |
Transactions in-progress are very inertial. To prevent the initial windup let's delay TPS adjustment by a couple of minutes.