Fix/simplify value store span attribute setup

[pattyshack]

This bug has been here for a while, prior to the environment refactoring. The extra negation on IsSample check meant that we were setting up span attribute on only non-sampled transactions. Nothing got logged.

[github-actions]

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 5b2986f

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	28.8ms ±12%	27.8ms ± 2%	~	(p=0.445 n=7+6)
RuntimeTransaction/convert_int_to_string-2	31.4ms ±16%	31.6ms ± 9%	~	(p=1.000 n=7+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	31.1ms ± 2%	30.7ms ± 3%	~	(p=0.209 n=7+7)
RuntimeTransaction/get_signer_address-2	29.4ms ±13%	30.9ms ±16%	~	(p=0.710 n=7+7)
RuntimeTransaction/get_public_account-2	30.9ms ± 2%	31.2ms ± 4%	~	(p=0.628 n=6+7)
RuntimeTransaction/get_account_and_get_balance-2	251ms ± 1%	250ms ± 2%	~	(p=0.234 n=6+7)
RuntimeTransaction/get_account_and_get_storage_used-2	33.2ms ± 7%	32.3ms ± 4%	~	(p=0.209 n=7+7)
RuntimeTransaction/get_signer_vault-2	35.0ms ± 3%	35.3ms ± 4%	~	(p=0.805 n=7+7)
RuntimeTransaction/get_signer_receiver-2	44.2ms ± 3%	44.8ms ± 6%	~	(p=0.805 n=7+7)
RuntimeTransaction/transfer_tokens-2	187ms ± 2%	186ms ± 2%	~	(p=0.620 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	34.8ms ± 6%	34.3ms ± 2%	~	(p=0.456 n=7+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	74.8ms ± 3%	75.2ms ± 2%	~	(p=0.639 n=7+5)
RuntimeTransaction/call_empty_contract_function-2	31.1ms ± 2%	30.7ms ± 3%	~	(p=0.181 n=6+7)
RuntimeTransaction/emit_event-2	46.3ms ± 2%	45.0ms ± 6%	~	(p=0.295 n=6+7)
RuntimeTransaction/borrow_array_from_storage-2	127ms ± 3%	128ms ± 2%	~	(p=0.620 n=7+7)
RuntimeTransaction/copy_array_from_storage-2	128ms ± 2%	127ms ± 1%	~	(p=0.073 n=7+6)
RuntimeNFTBatchTransfer-2	117ms ± 3%	116ms ± 4%	~	(p=0.456 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	4.27s ± 1%	4.30s ± 2%	~	(p=0.902 n=7+7)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/create_new_account-2	805ms ± 1%	794ms ± 2%	−1.36%	(p=0.011 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	207ms ± 1%	203ms ± 2%	−1.92%	(p=0.014 n=6+7)
RuntimeTransaction/get_account_and_get_available_balance-2	224ms ± 2%	219ms ± 1%	−2.22%	(p=0.002 n=7+7)
	computation		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	502 ± 0%	502 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	302 ± 0%	302 ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	1.00k ± 0%	1.00k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.70k ± 0%	1.70k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	3.50k ± 0%	3.50k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
	interactions		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	212k ± 0%	212k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	212k ± 0%	212k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	212k ± 0%	212k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	212k ± 0%	212k ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	212k ± 0%	212k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	23.8M ± 0%	23.8M ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	5.43M ± 0%	5.43M ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	212k ± 0%	212k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	5.43M ± 0%	5.43M ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	212k ± 0%	212k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	212k ± 0%	212k ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	212k ± 0%	212k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	212k ± 0%	212k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	215k ± 0%	215k ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	12.0M ± 0%	12.0M ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	213k ± 0%	213k ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	213k ± 0%	213k ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	218k ± 0%	218k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	218k ± 0%	218k ± 0%	~	(all equal)
	alloc/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/get_signer_address-2	34.2MB ± 2%	35.1MB ± 2%	+2.52%	(p=0.002 n=7+7)
RuntimeTransaction/reference_tx-2	34.6MB ± 4%	34.3MB ± 4%	~	(p=0.535 n=7+7)
RuntimeTransaction/convert_int_to_string-2	35.0MB ± 3%	35.0MB ± 3%	~	(p=0.945 n=6+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	35.2MB ± 2%	35.1MB ± 3%	~	(p=0.710 n=7+7)
RuntimeTransaction/get_public_account-2	36.0MB ± 1%	36.4MB ± 2%	~	(p=0.138 n=6+7)
RuntimeTransaction/get_account_and_get_storage_used-2	36.4MB ± 4%	35.3MB ± 4%	~	(p=0.097 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	103MB ± 1%	101MB ± 5%	~	(p=0.259 n=7+7)
RuntimeTransaction/get_signer_vault-2	36.0MB ± 3%	36.6MB ± 5%	~	(p=0.209 n=7+7)
RuntimeTransaction/get_signer_receiver-2	39.7MB ± 3%	40.4MB ± 7%	~	(p=0.710 n=7+7)
RuntimeTransaction/transfer_tokens-2	81.5MB ± 2%	82.8MB ± 2%	~	(p=0.445 n=7+6)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	35.7MB ± 3%	35.5MB ± 1%	~	(p=0.628 n=7+6)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	52.5MB ± 3%	52.7MB ± 3%	~	(p=1.000 n=7+7)
RuntimeTransaction/create_new_account-2	187MB ± 3%	183MB ± 2%	~	(p=0.128 n=7+7)
RuntimeTransaction/call_empty_contract_function-2	35.6MB ± 2%	35.1MB ± 3%	~	(p=0.165 n=7+7)
RuntimeTransaction/emit_event-2	41.9MB ± 3%	40.7MB ± 7%	~	(p=0.628 n=6+7)
RuntimeTransaction/borrow_array_from_storage-2	69.5MB ± 2%	70.3MB ± 3%	~	(p=0.620 n=7+7)
RuntimeTransaction/copy_array_from_storage-2	81.5MB ± 2%	81.7MB ± 2%	~	(p=1.000 n=7+7)
RuntimeNFTBatchTransfer-2	54.2MB ± 4%	55.3MB ± 2%	~	(p=0.138 n=7+6)
RuntimeTransaction/get_account_and_get_available_balance-2	104MB ± 3%	103MB ± 2%	−1.38%	(p=0.038 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	1.19GB ± 0%	1.17GB ± 1%	−1.44%	(p=0.001 n=6+7)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/get_account_and_get_balance-2	123MB ± 1%	121MB ± 2%	−2.00%	(p=0.007 n=7+7)
	allocs/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/transfer_tokens-2	839k ± 0%	838k ± 0%	−0.14%	(p=0.003 n=5+7)
RuntimeTransaction/borrow_array_from_storage-2	333k ± 0%	332k ± 0%	−0.37%	(p=0.001 n=7+7)
RuntimeTransaction/copy_array_from_storage-2	290k ± 0%	288k ± 0%	−0.43%	(p=0.001 n=6+7)
RuntimeTransaction/get_signer_receiver-2	195k ± 0%	193k ± 0%	−0.58%	(p=0.001 n=7+7)
RuntimeTransaction/emit_event-2	134k ± 0%	133k ± 0%	−0.80%	(p=0.001 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-2	116k ± 0%	115k ± 0%	−0.85%	(p=0.001 n=7+7)
RuntimeTransaction/get_signer_vault-2	120k ± 0%	119k ± 0%	−0.89%	(p=0.001 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	118k ± 0%	117k ± 0%	−0.90%	(p=0.001 n=7+7)
RuntimeTransaction/get_public_account-2	106k ± 0%	105k ± 0%	−0.92%	(p=0.001 n=7+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	103k ± 0%	102k ± 0%	−0.95%	(p=0.001 n=7+7)
RuntimeTransaction/convert_int_to_string-2	91.6k ± 0%	90.7k ± 0%	−1.06%	(p=0.001 n=7+7)
RuntimeTransaction/call_empty_contract_function-2	95.0k ± 0%	94.0k ± 0%	−1.12%	(p=0.003 n=5+7)
RuntimeTransaction/get_signer_address-2	83.6k ± 0%	82.6k ± 0%	−1.17%	(p=0.000 n=6+7)
RuntimeTransaction/reference_tx-2	79.4k ± 0%	78.4k ± 0%	−1.23%	(p=0.002 n=6+6)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	16.9M ± 0%	16.6M ± 0%	−1.76%	(p=0.001 n=7+7)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/get_account_and_get_balance-2	1.32M ± 0%	1.29M ± 0%	−1.90%	(p=0.001 n=7+7)
RuntimeNFTBatchTransfer-2	269k ± 0%	264k ± 1%	−1.94%	(p=0.003 n=5+7)
RuntimeTransaction/get_account_and_get_available_balance-2	1.20M ± 0%	1.17M ± 0%	−2.09%	(p=0.001 n=7+7)
RuntimeTransaction/create_new_account-2	2.31M ± 0%	2.26M ± 0%	−2.12%	(p=0.001 n=7+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	194k ± 0%	189k ± 0%	−2.13%	(p=0.001 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.12M ± 0%	1.10M ± 0%	−2.23%	(p=0.001 n=7+7)
	us/tx		delta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	2.08k ± 1%	2.10k ± 2%	~	(p=0.875 n=7+7)

[pattyshack]

bors merge

[bors]

Build succeeded:

• Integration Tests (make -C integration access-tests)
• Integration Tests (make -C integration bft-tests)
• Integration Tests (make -C integration collection-tests)
• Integration Tests (make -C integration consensus-tests)
• Integration Tests (make -C integration epochs-tests)
• Integration Tests (make -C integration execution-tests)
• Integration Tests (make -C integration ghost-tests)
• Integration Tests (make -C integration mvp-tests)
• Integration Tests (make -C integration network-tests)
• Integration Tests (make -C integration verification-tests)
• Lint (./)
• Lint (./crypto/)
• Lint (./integration/)
• Unit Tests (access)
• Unit Tests (admin)
• Unit Tests (cmd)
• Unit Tests (consensus)
• Unit Tests (engine)
• Unit Tests (fvm)
• Unit Tests (ledger)
• Unit Tests (module)
• Unit Tests (network)
• Unit Tests (others)
• Unit Tests (utils)