Skip to content

Modify Service Event encoding to be compatible with CBOR "strict" mode #5535

Open

Description

Context

We would like to change the global CBOR Decoder to use strict mode (see #5534). This is incompatible with the current implementation of service event decoding (see discussion #5428 (comment)).

Change service event encoding to be compatible with CBOR strict mode. Some implementation ideas:

  • Separately encode the inner specific event type as a separate encode step
type ServiceEvent struct {
  Type string
  Event []byte
}
  • Keep the existing ServiceEvent type, override "strict" mode for outer decode to read the Type field, then decode the specific inner event type with "strict" mode

Definition of Done

  • Service event decoding should function without errors when CBOR "strict" mode is enabled globally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

PreserveStale Bot repellentProtocolTeam: Issues assigned to the Protocol Pillar.S-BFT

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions