Skip to content

[FVM] Removing obsolete settings #2916

Open

Description

Problem Definition

As the FVM matures, some settings are no longer needed. Continuing support for those settings increases the complexity of the code and the amount of code paths that need to be tested.

Proposed Solution

  • TransactionFeesEnabled should be removed. If a situation requires the transaction fees to be disabled, they should be set to 0 instead.
  • MaxNumOfTxRetries is not used and should be removed.
  • restrictedAccountCreationEnabled will not be used anymore.
  • RestrictContractDeployment and RestrictContractRemoval and MemoryLimit are FVM variables and constants in the state, where the state constants take precedence. They should move to the state completely and the FVM settings removed. This can be done after canary, testnet and mainnet have the settings set in the state.
  • LimitAccountStorage should be always enabled, and the setting removed. (could cause problems in tests)
  • AllowContextOverrideByExecutionState was a temp workaround to allow the system transaction to run with more resources. An alternate solution should be found.

Some of these also require core contract changes (cleanups).

Definition of Done

  • Remove the mentioned settings
  • Check for any other FVM settings that can be removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

ExecutionCadence Execution Team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions