Skip to content

[Execution State] Add extra logging in execution node #2074

@fxamacker

Description

@fxamacker

Problem

Some error(s), warnings, and other useful information are not currently logged.

Examples:

  • It can be useful to log CPU info (model, family, logical cores, etc.) for various reasons. If EN specs fluctuate between Broadwell and Cascade Lake with substantial GHz difference, then having that info can be useful when deploying optimizations and making comparisons to past performance.
  • It can be useful to log a warning if some activity based on dynamic or stored data is going to use a suspiciously large percent of total installed RAM. If we ever run out of RAM, then such a log can help us save time investigating crash loops, etc.
  • There's at least one error not logged which was noticed during PR #1944 but it's out of scope for that PR and located outside checkpoint code.

The Proposed Solution

  • Log some useful info (e.g. cpu info), warnings (see above), and errors.
  • Avoid spamming the log with noise.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions