Skip to content

Commit

Permalink
Improve verification test's error message
Browse files Browse the repository at this point in the history
When chunk verifier returns a chunk fault/error, a placeholder signature is
generated for that chunk.
  • Loading branch information
pattyshack committed Dec 22, 2022
1 parent 9c5fffa commit e08ea68
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion engine/verification/utils/unittest/helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,24 @@ func SetupMockConsensusNode(t *testing.T,
hasher,
)
assert.NoError(t, err)
assert.True(t, valid)

if !valid {
// When chunk verifier returns chunk fault, a placeholder
// signature is generated for that chunk.
isChunkFaultSignature, err := crypto.SPOCKVerifyAgainstData(
pk,
resultApproval.Body.Spock,
nil, // chunk fault has no spock secret
hasher,
)
assert.NoError(t, err)

if isChunkFaultSignature {
assert.Fail(t, "chunk verifier returned chunk fault")
} else {
assert.Fail(t, "spock secret mismatch")
}
}

wg.Done()
}).Return(nil)
Expand Down

0 comments on commit e08ea68

Please sign in to comment.