Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix query param for getExecutionResults #487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix query param for getExecutionResults #487

wants to merge 1 commit into from

Conversation

treethought
Copy link

Closes: #486

Description

Aligns the query param for getExecutionResults with the API spec

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@treethought treethought force-pushed the treethought/executionresult-param branch from fae71cf to 20a6735 Compare October 13, 2023 22:41
@chasefleming
Copy link
Member

Thanks for catching this @treethought ! Can we make this fail with previous code so that this doesn't get through again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@sideninja sideninja Awaiting requested review from sideninja

@chasefleming chasefleming Awaiting requested review from chasefleming chasefleming is a code owner

@nvdtf nvdtf Awaiting requested review from nvdtf nvdtf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetExecutionResultForBlockID uses wrong query param
2 participants
@treethought @chasefleming