Apply block overrides in eth_estimateGas JSON-RPC endpoint
#876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-Peter
requested review from
janezpodhostnik,
peterargue and
zhangchiqing
as code owners
Contributor
WalkthroughAdds blockOverrides support to eth_estimateGas by updating API and requester/EVM signatures to accept and forward block-level overrides into the EVM dry-run path, and adds e2e Web3.js tests and fixtures validating gas estimates with various block overrides. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant API as BlockChainAPI
participant Requester as Requester/EVM
participant EVM as dryRunTx
Note over Client,API: eth_estimateGas (may include blockOverrides)
Client->>API: EstimateGas(ctx, txArgs, blockNumOrHash, stateOverrides, blockOverrides)
API->>Requester: EstimateGas(txArgs, from, height, stateOverrides, blockOverrides)
Requester->>EVM: dryRunTx(..., stateOverrides, blockOverrides)
EVM-->>Requester: gasUsed
Requester-->>API: gasUsed
API-->>Client: hex gasUsed
Note right of EVM: Block view assembled with overrides\n(number, timestamp, prevrandao, coinbase)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (5 passed)✅ Passed checks (5 passed)
Poem
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
services/requester/requester.go (1)
346-351: Cap by overridden block gas limit and fix underflow in failingGasLimit
- If blockOverrides.GasLimit is set, passingGasLimit should be capped by it to match geth semantics; otherwise the first dryRun can exceed the overridden block limit.
- failingGasLimit = result.GasConsumed - 1 underflows when GasConsumed == 0.
Apply this diff:
// Determine the highest gas limit that can be used during the estimation. passingGasLimit = blockGasLimit if txArgs.Gas != nil && (uint64(*txArgs.Gas) >= gethParams.TxGas) { passingGasLimit = uint64(*txArgs.Gas) } + // Cap by overridden block gas limit if provided + if blockOverrides != nil && blockOverrides.GasLimit != nil { + if uint64(*blockOverrides.GasLimit) < passingGasLimit { + passingGasLimit = uint64(*blockOverrides.GasLimit) + } + } @@ - failingGasLimit = result.GasConsumed - 1 + if result.GasConsumed > 0 { + failingGasLimit = result.GasConsumed - 1 + } else { + failingGasLimit = 0 + }Also applies to: 376-376
🧹 Nitpick comments (4)
services/requester/requester.go (1)
337-345: Minor robustness nits in estimator loop
- Consider clamping optimisticGasLimit to passingGasLimit before calling dryRun to avoid redundant high-gas calls when caps are tight.
- In the bisection step, if mid > passingGasLimit due to arithmetic, clamp mid to passingGasLimit.
These are defensive and won’t change outcomes in nominal cases.
Also applies to: 381-394, 405-419
tests/web3js/estimate_gas_overrides_test.js (3)
39-39: Fix Number vs BigInt comparisons for stabilityweb3.utils.hexToNumber returns a Number, but expectations use BigInt literals (…n). Compare BigInt-to-BigInt to avoid surprises.
Apply this diff:
- assert.equal(web3.utils.hexToNumber(response.body.result), 21651n) + assert.strictEqual(BigInt(response.body.result), 21651n) @@ - assert.equal(web3.utils.hexToNumber(response.body.result), 21651n) + assert.strictEqual(BigInt(response.body.result), 21651n) @@ - assert.equal(web3.utils.hexToNumber(response.body.result), 21607n) + assert.strictEqual(BigInt(response.body.result), 21607n) @@ - assert.equal(web3.utils.hexToNumber(response.body.result), 21607n) + assert.strictEqual(BigInt(response.body.result), 21607n) @@ - assert.equal(web3.utils.hexToNumber(response.body.result), 21584n) + assert.strictEqual(BigInt(response.body.result), 21584n)Also applies to: 48-48, 60-60, 69-69, 90-90
22-49: Reduce brittleness: assert invariance/difference rather than exact gas valuesExact gas values (21651, 21607, 21584) can drift with EVM changes. Prefer asserting:
- block.number/time overrides do not affect gas (equal before/after).
- prevrandao override may affect gas (different before/after).
I can propose a patch if you want to switch to relational assertions.
Also applies to: 50-70, 71-91
22-49: Add a test for blockOverrides.gasLimit cappingOnce EstimateGas caps by overridden GasLimit, add a case that sets a low gasLimit override and asserts estimatedGas <= that cap (or appropriate failure). This guards the intended semantics.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
api/api.go(2 hunks)services/requester/requester.go(2 hunks)tests/e2e_web3js_test.go(1 hunks)tests/web3js/estimate_gas_overrides_test.js(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (3)
tests/e2e_web3js_test.go (1)
bootstrap/bootstrap.go (1)
Run(707-723)
api/api.go (1)
eth/types/types.go (1)
BlockOverrides(450-459)
services/requester/requester.go (1)
eth/types/types.go (1)
BlockOverrides(450-459)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (6)
services/requester/requester.go (3)
66-72: Plumbing blockOverrides through Call: LGTMThe additional blockOverrides parameter is correctly threaded into Call and passed down to the dry-run path.
76-83: Add blockOverrides to EstimateGas: LGTMSignature and interface update look consistent with the Call path and API layer.
324-333: Ensure dry-run honors block overrides in gas estimationPassing blockOverrides into dryRunTx is correct and aligns EstimateGas with eth_call behavior.
api/api.go (2)
696-697: Expose blockOverrides in eth_estimateGas: LGTMAPI surface matches geth v1.15.0 calling convention.
727-733: Forward blockOverrides to backend: LGTMCorrectly forwards overrides to the requester’s EstimateGas.
tests/e2e_web3js_test.go (1)
49-51: Good coverage: adds an end-to-end estimateGas override testPlacement in the suite and wiring via runWeb3Test look good.
janezpodhostnik
approved these changes
Sep 11, 2025
m-Peter
force-pushed
the
mpeter/estimate-gas-with-block-overrides
branch
from
73dab2a to
3ef41ff
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
tests/fixtures/blockOverrides.sol (2)
24-26: Make the address type explicit in the coinbase comparison.Avoid relying on implicit conversions; compare against an
address(...).- if (block.coinbase == 0x658Bdf435d810C91414eC09147DAA6DB62406379) { + if (block.coinbase == address(0x658Bdf435d810C91414eC09147DAA6DB62406379)) {
8-11: Fix typo in comment."overrided" → "overridden".
- // overrided, resulting in higher gas usage. + // overridden, resulting in higher gas usage.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
api/api.go(2 hunks)services/requester/requester.go(2 hunks)tests/e2e_web3js_test.go(1 hunks)tests/fixtures/blockOverrides.byte(1 hunks)tests/fixtures/blockOverrides.sol(1 hunks)tests/fixtures/blockOverridesABI.json(1 hunks)tests/web3js/estimate_gas_overrides_test.js(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- tests/fixtures/blockOverrides.byte
- tests/fixtures/blockOverridesABI.json
🚧 Files skipped from review as they are similar to previous changes (3)
- tests/e2e_web3js_test.go
- api/api.go
- services/requester/requester.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (1)
tests/web3js/estimate_gas_overrides_test.js (1)
41-45: Sanity-check field names match Geth’s block override schema.Keys look correct (
number,time,random,coinbase). Keep as-is; just noting for future maintainers.If you want, I can add a follow-up test that sets multiple overrides at once to validate additive gas effects.
Also applies to: 59-63, 77-82, 96-100
| @@ -0,0 +1,36 @@ | |||
| // SPDX-License-Identifier: GPL-3.0 | |||
|
|
|||
| pragma solidity >=0.8.2 <0.9.0; | |||
Contributor
There was a problem hiding this comment.
Bump pragma to ensure block.prevrandao exists (>=0.8.18).
block.prevrandao wasn’t available before 0.8.18; the current range allows compilers that will fail. Tighten the lower bound.
-pragma solidity >=0.8.2 <0.9.0;
+pragma solidity >=0.8.18 <0.9.0;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| pragma solidity >=0.8.2 <0.9.0; | |
| pragma solidity >=0.8.18 <0.9.0; |
🤖 Prompt for AI Agents
In tests/fixtures/blockOverrides.sol around line 3, the pragma range allows
compilers older than 0.8.18 which lack block.prevrandao; update the pragma to
require at least 0.8.18 by changing the lower bound from 0.8.2 to 0.8.18 (i.e.,
make the pragma read "pragma solidity >=0.8.18 <0.9.0;") so the contract is
compiled with a version that supports block.prevrandao.
Comment on lines
+33
to
+104
| let response = await helpers.callRPCMethod( | ||
| 'eth_estimateGas', | ||
| [txArgs, 'latest', null, null] | ||
| ) | ||
| assert.equal(response.status, 200) | ||
| assert.isDefined(response.body) | ||
| assert.equal(web3.utils.hexToNumber(response.body.result), 21473n) | ||
|
|
||
| // Override the `block.number` value to `9090`. | ||
| response = await helpers.callRPCMethod( | ||
| 'eth_estimateGas', | ||
| [txArgs, 'latest', null, { number: '0x2382' }] | ||
| ) | ||
| assert.equal(response.status, 200) | ||
| assert.isDefined(response.body) | ||
| assert.equal(web3.utils.hexToNumber(response.body.result), 273693n) | ||
|
|
||
| // Check the `block.timestamp` value, without overrides | ||
| response = await helpers.callRPCMethod( | ||
| 'eth_estimateGas', | ||
| [txArgs, 'latest', null, null] | ||
| ) | ||
| assert.equal(response.status, 200) | ||
| assert.isDefined(response.body) | ||
| assert.equal(web3.utils.hexToNumber(response.body.result), 21473n) | ||
|
|
||
| // Override the `block.timestamp` value to `0x674DB1E1`. | ||
| response = await helpers.callRPCMethod( | ||
| 'eth_estimateGas', | ||
| [txArgs, 'latest', null, { time: '0x674DB1E1' }] | ||
| ) | ||
| assert.equal(response.status, 200) | ||
| assert.isDefined(response.body) | ||
| assert.equal(web3.utils.hexToNumber(response.body.result), 273693n) | ||
|
|
||
| // Check the `block.prevrandao` value, without overrides | ||
| response = await helpers.callRPCMethod( | ||
| 'eth_estimateGas', | ||
| [txArgs, 'latest', null, null] | ||
| ) | ||
| assert.equal(response.status, 200) | ||
| assert.isDefined(response.body) | ||
| assert.equal(web3.utils.hexToNumber(response.body.result), 21473n) | ||
|
|
||
| // Override the `block.prevrandao` value to `0x7914bb5b13bac6f621bc37bbf6e406fbf4472aaaaf17ec2f309a92aca4e27fc0`. | ||
| let random = '0x7914bb5b13bac6f621bc37bbf6e406fbf4472aaaaf17ec2f309a92aca4e27fc0' | ||
| response = await helpers.callRPCMethod( | ||
| 'eth_estimateGas', | ||
| [txArgs, 'latest', null, { random: random }] | ||
| ) | ||
| assert.equal(response.status, 200) | ||
| assert.isDefined(response.body) | ||
| assert.equal(web3.utils.hexToNumber(response.body.result), 273693n) | ||
|
|
||
| // Check the `block.coinbase` value, without overrides | ||
| response = await helpers.callRPCMethod( | ||
| 'eth_estimateGas', | ||
| [txArgs, 'latest', null, null] | ||
| ) | ||
| assert.equal(response.status, 200) | ||
| assert.isDefined(response.body) | ||
| assert.equal(web3.utils.hexToNumber(response.body.result), 21473n) | ||
|
|
||
| // Override the `block.coinbase` value to `0x658Bdf435d810C91414eC09147DAA6DB62406379`. | ||
| response = await helpers.callRPCMethod( | ||
| 'eth_estimateGas', | ||
| [txArgs, 'latest', null, { coinbase: '0x658Bdf435d810C91414eC09147DAA6DB62406379' }] | ||
| ) | ||
| assert.equal(response.status, 200) | ||
| assert.isDefined(response.body) | ||
| assert.equal(web3.utils.hexToNumber(response.body.result), 273693n) | ||
| }) |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion
Avoid brittle exact gas assertions; compare against baseline and parse as BigInt.
Exact gas varies by solc/EVM settings. Capture baseline once and assert overrides increase it. Also use hexToNumberString + BigInt to avoid 53-bit issues.
- let response = await helpers.callRPCMethod(
+ let response = await helpers.callRPCMethod(
'eth_estimateGas',
[txArgs, 'latest', null, null]
)
assert.equal(response.status, 200)
assert.isDefined(response.body)
- assert.equal(web3.utils.hexToNumber(response.body.result), 21473n)
+ const baselineGas = BigInt(web3.utils.hexToNumberString(response.body.result))
// Override the `block.number` value to `9090`.
response = await helpers.callRPCMethod(
'eth_estimateGas',
[txArgs, 'latest', null, { number: '0x2382' }]
)
assert.equal(response.status, 200)
assert.isDefined(response.body)
- assert.equal(web3.utils.hexToNumber(response.body.result), 273693n)
+ let gas = BigInt(web3.utils.hexToNumberString(response.body.result))
+ assert.isTrue(gas > baselineGas, 'block.number override should increase gas')
// Check the `block.timestamp` value, without overrides
response = await helpers.callRPCMethod(
'eth_estimateGas',
[txArgs, 'latest', null, null]
)
assert.equal(response.status, 200)
assert.isDefined(response.body)
- assert.equal(web3.utils.hexToNumber(response.body.result), 21473n)
+ gas = BigInt(web3.utils.hexToNumberString(response.body.result))
+ assert.equal(gas, baselineGas)
// Override the `block.timestamp` value to `0x674DB1E1`.
response = await helpers.callRPCMethod(
'eth_estimateGas',
[txArgs, 'latest', null, { time: '0x674DB1E1' }]
)
assert.equal(response.status, 200)
assert.isDefined(response.body)
- assert.equal(web3.utils.hexToNumber(response.body.result), 273693n)
+ gas = BigInt(web3.utils.hexToNumberString(response.body.result))
+ assert.isTrue(gas > baselineGas, 'block.timestamp override should increase gas')
// Check the `block.prevrandao` value, without overrides
response = await helpers.callRPCMethod(
'eth_estimateGas',
[txArgs, 'latest', null, null]
)
assert.equal(response.status, 200)
assert.isDefined(response.body)
- assert.equal(web3.utils.hexToNumber(response.body.result), 21473n)
+ gas = BigInt(web3.utils.hexToNumberString(response.body.result))
+ assert.equal(gas, baselineGas)
// Override the `block.prevrandao` value to `0x7914bb5b13...`.
let random = '0x7914bb5b13bac6f621bc37bbf6e406fbf4472aaaaf17ec2f309a92aca4e27fc0'
response = await helpers.callRPCMethod(
'eth_estimateGas',
[txArgs, 'latest', null, { random: random }]
)
assert.equal(response.status, 200)
assert.isDefined(response.body)
- assert.equal(web3.utils.hexToNumber(response.body.result), 273693n)
+ gas = BigInt(web3.utils.hexToNumberString(response.body.result))
+ assert.isTrue(gas > baselineGas, 'prevrandao override should increase gas')
// Check the `block.coinbase` value, without overrides
response = await helpers.callRPCMethod(
'eth_estimateGas',
[txArgs, 'latest', null, null]
)
assert.equal(response.status, 200)
assert.isDefined(response.body)
- assert.equal(web3.utils.hexToNumber(response.body.result), 21473n)
+ gas = BigInt(web3.utils.hexToNumberString(response.body.result))
+ assert.equal(gas, baselineGas)
// Override the `block.coinbase` value to `0x658Bdf...`.
response = await helpers.callRPCMethod(
'eth_estimateGas',
[txArgs, 'latest', null, { coinbase: '0x658Bdf435d810C91414eC09147DAA6DB62406379' }]
)
assert.equal(response.status, 200)
assert.isDefined(response.body)
- assert.equal(web3.utils.hexToNumber(response.body.result), 273693n)
+ gas = BigInt(web3.utils.hexToNumberString(response.body.result))
+ assert.isTrue(gas > baselineGas, 'coinbase override should increase gas')📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| let response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, null] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| assert.equal(web3.utils.hexToNumber(response.body.result), 21473n) | |
| // Override the `block.number` value to `9090`. | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, { number: '0x2382' }] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| assert.equal(web3.utils.hexToNumber(response.body.result), 273693n) | |
| // Check the `block.timestamp` value, without overrides | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, null] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| assert.equal(web3.utils.hexToNumber(response.body.result), 21473n) | |
| // Override the `block.timestamp` value to `0x674DB1E1`. | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, { time: '0x674DB1E1' }] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| assert.equal(web3.utils.hexToNumber(response.body.result), 273693n) | |
| // Check the `block.prevrandao` value, without overrides | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, null] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| assert.equal(web3.utils.hexToNumber(response.body.result), 21473n) | |
| // Override the `block.prevrandao` value to `0x7914bb5b13bac6f621bc37bbf6e406fbf4472aaaaf17ec2f309a92aca4e27fc0`. | |
| let random = '0x7914bb5b13bac6f621bc37bbf6e406fbf4472aaaaf17ec2f309a92aca4e27fc0' | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, { random: random }] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| assert.equal(web3.utils.hexToNumber(response.body.result), 273693n) | |
| // Check the `block.coinbase` value, without overrides | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, null] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| assert.equal(web3.utils.hexToNumber(response.body.result), 21473n) | |
| // Override the `block.coinbase` value to `0x658Bdf435d810C91414eC09147DAA6DB62406379`. | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, { coinbase: '0x658Bdf435d810C91414eC09147DAA6DB62406379' }] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| assert.equal(web3.utils.hexToNumber(response.body.result), 273693n) | |
| }) | |
| let response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, null] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| const baselineGas = BigInt(web3.utils.hexToNumberString(response.body.result)) | |
| // Override the `block.number` value to `9090`. | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, { number: '0x2382' }] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| let gas = BigInt(web3.utils.hexToNumberString(response.body.result)) | |
| assert.isTrue(gas > baselineGas, 'block.number override should increase gas') | |
| // Check the `block.timestamp` value, without overrides | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, null] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| gas = BigInt(web3.utils.hexToNumberString(response.body.result)) | |
| assert.equal(gas, baselineGas) | |
| // Override the `block.timestamp` value to `0x674DB1E1`. | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, { time: '0x674DB1E1' }] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| gas = BigInt(web3.utils.hexToNumberString(response.body.result)) | |
| assert.isTrue(gas > baselineGas, 'block.timestamp override should increase gas') | |
| // Check the `block.prevrandao` value, without overrides | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, null] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| gas = BigInt(web3.utils.hexToNumberString(response.body.result)) | |
| assert.equal(gas, baselineGas) | |
| // Override the `block.prevrandao` value to `0x7914bb5b13bac6f621bc37bbf6e406fbf4472aaaaf17ec2f309a92aca4e27fc0`. | |
| let random = '0x7914bb5b13bac6f621bc37bbf6e406fbf4472aaaaf17ec2f309a92aca4e27fc0' | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, { random: random }] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| gas = BigInt(web3.utils.hexToNumberString(response.body.result)) | |
| assert.isTrue(gas > baselineGas, 'prevrandao override should increase gas') | |
| // Check the `block.coinbase` value, without overrides | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, null] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| gas = BigInt(web3.utils.hexToNumberString(response.body.result)) | |
| assert.equal(gas, baselineGas) | |
| // Override the `block.coinbase` value to `0x658Bdf435d810C91414eC09147DAA6DB62406379`. | |
| response = await helpers.callRPCMethod( | |
| 'eth_estimateGas', | |
| [txArgs, 'latest', null, { coinbase: '0x658Bdf435d810C91414eC09147DAA6DB62406379' }] | |
| ) | |
| assert.equal(response.status, 200) | |
| assert.isDefined(response.body) | |
| gas = BigInt(web3.utils.hexToNumberString(response.body.result)) | |
| assert.isTrue(gas > baselineGas, 'coinbase override should increase gas') | |
| }) |
🤖 Prompt for AI Agents
In tests/web3js/estimate_gas_overrides_test.js around lines 33 to 104, the test
uses brittle exact gas assertions; instead capture a single baseline gas result
(call eth_estimateGas once with no overrides), convert results using
web3.utils.hexToNumberString and BigInt, then for each override call assert
BigInt(overrideResult) > BigInt(baseline) (or >= if appropriate) rather than
comparing to hardcoded numbers; update all comparisons to parse via
hexToNumberString+BigInt and remove the fixed numeric literals.
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #791
Description
Just like
eth_call,eth_estimateGasalso includes support for overriding certain block header fields.This was added in Geth, as part of ethereum/go-ethereum#30695 .
For contributor use:
masterbranchFiles changedin the Github PR explorerSummary by CodeRabbit
New Features
Tests