Skip to content

Conversation

@turbolent
Copy link
Member

@turbolent turbolent changed the title Auto update to onflow/cadence v0.39.2 Update to latest Go SDK and flow-go Jun 6, 2023
@turbolent
Copy link
Member Author

Some tests are failing re: CCF.

Do we maybe need onflow/flow-go#4417 here @fxamacker? (not urgent)

@fxamacker
Copy link
Member

Do we maybe need onflow/flow-go#4417 here @fxamacker? (not urgent)

Yes, this needs flow-go with PR 4417. Just merged.

@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label Jun 7, 2023
@turbolent turbolent self-assigned this Jun 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #409 (fe38aee) into master (3ba3526) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
- Coverage   52.02%   51.90%   -0.12%     
==========================================
  Files          27       27              
  Lines        3337     3337              
==========================================
- Hits         1736     1732       -4     
- Misses       1463     1466       +3     
- Partials      138      139       +1     
Flag Coverage Δ
unittests 51.90% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@turbolent turbolent merged commit 5647df1 into master Jun 7, 2023
@turbolent turbolent deleted the auto-update-onflow-cadence-v0.39.2 branch June 7, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants