Implementation for FLIP 332: Stricter Validation of Node Network Addresses

contracts/FlowIDTableStaking.cdc

@@ -166,7 +166,7 @@ access(all) contract FlowIDTableStaking {
                 FlowIDTableStaking.isValidNodeID(id): "The node ID must have only numbers and lowercase hex characters"
                 FlowIDTableStaking.nodes[id] == nil: "The ID cannot already exist in the record"
                 role >= UInt8(1) && role <= UInt8(5): "The role must be 1, 2, 3, 4, or 5"
-                networkingAddress.length > 0 && networkingAddress.length <= 510: "The networkingAddress must be less than 510 characters"
+                FlowIDTableStaking.isValidNetworkingAddress(address: networkingAddress): "The networkingAddress must be a valid domain name with a port (e.g., node.flow.com:3569), must not exceed 510 characters, and cannot be an IP address"
                 networkingKey.length == 128: "The networkingKey length must be exactly 64 bytes (128 hex characters)"
                 stakingKey.length == 192: "The stakingKey length must be exactly 96 bytes (192 hex characters)"
                 !FlowIDTableStaking.getNetworkingAddressClaimed(address: networkingAddress): "The networkingAddress cannot have already been claimed"
@@ -437,7 +437,7 @@ access(all) contract FlowIDTableStaking {
         access(NodeOperator) fun updateNetworkingAddress(_ newAddress: String) {
             pre {
                 FlowIDTableStaking.stakingEnabled(): "Cannot update networking address if the staking auction isn't in progress"
-                newAddress.length > 0 && newAddress.length <= 510: "The networkingAddress must be less than 510 characters"
+                FlowIDTableStaking.isValidNetworkingAddress(address: newAddress): "The networkingAddress must be a valid domain name with a port (e.g., node.flow.com:3569), must not exceed 510 characters, and cannot be an IP address"
                 !FlowIDTableStaking.getNetworkingAddressClaimed(address: newAddress): "The networkingAddress cannot have already been claimed"
             }
 
@@ -1822,6 +1822,92 @@ access(all) contract FlowIDTableStaking {
         return true
     }
 
+    /// Validates that a networking address is properly formatted
+    /// Requirements:
+    /// 1. Must not be an IP address
+    /// 2. Must contain a port number after a colon
+    /// 3. Must be a valid domain name format
+    access(contract) view fun isValidNetworkingAddress(address: String): Bool {
+        // Check length
+       if  address.length == 0 && address.length > 510 {
+            return false
+        }
+
+        // Split the address into domain and port
+        let parts = address.split(separator: ":")
+        if parts.length != 2 {
+            return false
+        }
+
+        let domain = parts[0]
+        let port = parts[1]
+
+        // Check if port is a valid number between 1 and 65535
+        let portNum = UInt16.fromString(port)
+        if portNum == nil || portNum! < 1 || portNum! > 65535 {
+            return false
+        }
+
+        // Check if domain has at least one dot and valid characters
+        if !domain.contains(".") {
+            return false
+        }
+
+        // Check if domain contains only letters, digits and hyphens
+        let validChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789.-".utf8
+        for char in domain.utf8 {
+            if !validChars.contains(char) {
+                return false
+            }
+        }
+
+        let hyphen = "-".utf8[0]
+        let labels = domain.split(separator: ".")
+        for label in labels {
+            // Label should not be empty
+            if label.length == 0 {
+                return false
+            }
+
+            // Label should not start or ends with a hyphen
+            var labelChars = label.utf8
+            if labelChars[0] == hyphen || labelChars[labelChars.length - 1] == hyphen {
+                    return false
+            }
+        }
+
+        let tld = labels[labels.length - 1]
+
+        // TLD must be atleast 2 characters long
+        if tld.length < 2 {
+            return false
+        }
+
+        // TLD must not be all digits
+        var hasLetter = false
+        for c in tld.utf8 {
+
+            // TLD must not contain a hyphen
+            if c == hyphen {
+                return false
+            }
+
+            // TLD must not be all digits
+            let isUpper = c >= 65 && c <= 90   // 'A'-'Z'
+            let isLower = c >= 97 && c <= 122  // 'a'-'z'
+            if isUpper || isLower {
+                hasLetter = true
+                break
+            }
+        }
+
+        if !hasLetter {
+            return false
+        }
+
+        return true
+    }
+
     /// Indicates if the staking auction is currently enabled
     access(all) view fun stakingEnabled(): Bool {
         return self.account.storage.copy<Bool>(from: /storage/stakingEnabled) ?? false

lib/go/test/epoch_test_helpers.go

@@ -500,7 +500,7 @@ func registerNodesForEpochs(
 			authorizer,
 			signers[i],
 			ids[i],
-			fmt.Sprintf("%0128d", i),
+			getNetworkingAddress(i),
 			networkingkeys[i],
 			stakingKeys[i],
 			stakingKeysPOPs[i],

lib/go/test/flow_idtable_nodes_test.go

@@ -137,7 +137,7 @@ func TestIDTableManyNodes(t *testing.T) {
 
 			nodeRoles[i] = cadence.NewUInt8(uint8((i % 4) + 1))
 
-			networkingAddress := fmt.Sprintf("%0128d", i)
+			networkingAddress := getNetworkingAddress(i)
 
 			nodeNetworkingAddresses[i] = CadenceString(networkingAddress)
 
@@ -446,7 +446,7 @@ func TestIDTableOutOfBoundsAccess(t *testing.T) {
 
 			nodeRoles[i] = cadence.NewUInt8(uint8((i % 4) + 1))
 
-			networkingAddress := fmt.Sprintf("%0128d", i)
+			networkingAddress := getNetworkingAddress(i)
 
 			nodeNetworkingAddresses[i] = CadenceString(networkingAddress)
 
@@ -608,7 +608,7 @@ func TestIDTableUnstakeAllManyDelegators(t *testing.T) {
 			require.NoError(t, err)
 			err = tx.AddArgument(cadence.NewUInt8(role))
 			require.NoError(t, err)
-			err = tx.AddArgument(CadenceString(fmt.Sprintf("%0128d", i)))
+			err = tx.AddArgument(CadenceString(getNetworkingAddress(i)))
 			require.NoError(t, err)
 			err = tx.AddArgument(CadenceString(networkingKey))
 			require.NoError(t, err)