Retract incorrectly tagged out-of-order version (v1.2.3)
#398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This marks the incorrectly tagged version as retracted, which means go tooling will no longer consider it the latest version (and won't attempt to automatically upgrade to it). In addition, once this is merged, we will need to tag v1.2.4: - this creates a new largest semver version, which go will consider as latest - go tooling will download this v1.2.4 version, read the retract statements, then correctly interpret the true latest version to be v0.X.Y This is needed because once a version is added to the sum.golang.org database, it is never removed (prioritizing build stability). See https://go.dev/ref/mod#checksum-database, which this change is based off, for more details.
jordanschalm
changed the title
v1.2.3)v1.2.3)
6 tasks
janezpodhostnik
approved these changes
Dec 6, 2023
joshuahannan
approved these changes
Dec 6, 2023
|
Tagged % go get github.com/onflow/flow-core-contracts/lib/go/contracts@v1.2.4
go: warning: github.com/onflow/flow-core-contracts/lib/go/contracts@v1.2.4: retracted by module author: contains retraction only
go: to switch to the latest unretracted version, run:
go get github.com/onflow/flow-core-contracts/lib/go/contracts@latest % go get github.com/onflow/flow-core-contracts/lib/go/contracts@latest
go: downgraded github.com/onflow/flow-core-contracts/lib/go/contracts v1.2.4 => v0.15.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A few months ago an out-of-order semver tag was pushed (
v1.2.3). The tag was removed from the repository, however, since it was depended on by another Go module before being removed, we also need to explicitly mark the version as retracted to fully correct the Go tooling's behaviour.Why is this a problem
@latestwill return versionv1.2.3rather than the actual most recent versiongo get -u ...) will "upgrade" thecore-contractsmodules tov1.2.3core-contractsmodule, one of which isv1.2.3(or any untagged commit afterv1.2.3), then Go will build withv1.2.3rather than the actual most recent versionHow this fixes the problem
This PR marks the incorrectly tagged version as retracted, which means go tooling will no longer consider it the latest version (and won't attempt to automatically upgrade to it).
In addition, once this is merged, we will need to tag v1.2.4:
This is needed because once a version is added to the sum.golang.org database, it is never removed (prioritizing build stability). See https://go.dev/ref/mod#checksum-database, which this change is based off, for more details.