PKG -- [fcl] Make errors accessible to subscribers from fcl.tx polling and throw for onceSealed, onceExecuted, onceFinalized #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jribbink
requested review from
JeffreyDoyle,
10thfloor,
gregsantos,
chasefleming,
justinbarry and
srinjoyc
as code owners
🦋 Changeset detectedLatest commit: 259f9ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gregsantos
suggested changes
Jun 9, 2022
Co-authored-by: Greg Santos <greg.santos@dapperlabs.com>
gregsantos
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
LGTM, @jribbink Assuming you kicked the tires on this pretty well.
This was referenced Jun 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.