Skip to content

Conversation

jribbink
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2022

🦋 Changeset detected

Latest commit: c189288

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/fcl Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JeffreyDoyle
Copy link
Member

Hey @jribbink , do you have a subsequent PR with code changes incoming or just this one doc update?

We'll also need to be sure to update the project to load first the flow.network variable , and then fall back to env variable in config wherever it's used and throw a deprecation warning if using the env config variable is used

Co-authored-by: Greg Santos <greg.santos@dapperlabs.com>
@jribbink jribbink force-pushed the jribbink/deprecate-env-config branch from 3fe9487 to f69bd3e Compare May 26, 2022 23:33
@jribbink jribbink requested a review from srinjoyc as a code owner June 13, 2022 22:02
@jribbink jribbink merged commit 457f499 into master Jun 13, 2022
@jribbink jribbink deleted the jribbink/deprecate-env-config branch June 13, 2022 22:06
@github-actions github-actions bot mentioned this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants