Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata views doc #448

Merged
merged 27 commits into from
Nov 21, 2023
Merged

Add metadata views doc #448

merged 27 commits into from
Nov 21, 2023

Conversation

chasefleming
Copy link
Member

No description provided.

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 8:08pm

docs/build/advanced-concepts/metadata-views.md Outdated Show resolved Hide resolved
docs/build/advanced-concepts/metadata-views.md Outdated Show resolved Hide resolved

# About NFT MetadataViews on Flow

`MetadataViews` on Flow offers a standardized way to represent metadata across different NFTs. With its integration, developers can ensure that different platforms and marketplaces can interpret the NFT metadata in a unified manner. This means that when you go to a marketplace, it looks and reads the same on this marketplace as it does on another, providing a consistent user experience across different platforms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to represent metadata like...across different NFTs
Would add a couple examples here

docs/build/advanced-concepts/metadata-views.md Outdated Show resolved Hide resolved
docs/build/advanced-concepts/metadata-views.md Outdated Show resolved Hide resolved
docs/build/advanced-concepts/metadata-views.md Outdated Show resolved Hide resolved
docs/build/advanced-concepts/metadata-views.md Outdated Show resolved Hide resolved
return MetadataViews.NFTCollectionData(
storagePath: ExampleNFT.CollectionStoragePath,
publicPath: ExampleNFT.CollectionPublicPath,
providerPath: /private/exampleNFTCollection,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a string, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it is a path, put private paths are going away so should we create a new Collection view?

Copy link
Contributor

@bjartek bjartek Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean we do not need type anymore after stable cadence, atleast not more then 1 type.

docs/build/advanced-concepts/metadata-views.md Outdated Show resolved Hide resolved
docs/build/advanced-concepts/metadata-views.md Outdated Show resolved Hide resolved
chasefleming and others added 9 commits November 14, 2023 09:43
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
@joshuahannan
Copy link
Member

I'm gonna pull this branch down and make a PR to it to add my edits, so don't merge it yet

chasefleming and others added 14 commits November 21, 2023 10:34
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
chasefleming and others added 2 commits November 21, 2023 10:42
Co-authored-by: Greg Santos <gregsantos@gmail.com>
Co-authored-by: Greg Santos <gregsantos@gmail.com>
@chasefleming chasefleming merged commit fddb801 into main Nov 21, 2023
3 checks passed
@chasefleming chasefleming deleted the chasefleming/metadata-views branch November 21, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants