Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the wasmtime VM for now #991

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jun 9, 2021

Description

Put the VM, which uses wasmtime, behind a build flag. Wasmtime does not work on M1 yet


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Jun 9, 2021
@turbolent turbolent added the Chore label Jun 9, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #991 (61ec74c) into master (eefa27c) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
+ Coverage   75.51%   75.55%   +0.03%     
==========================================
  Files         268      267       -1     
  Lines       32910    32852      -58     
==========================================
- Hits        24852    24820      -32     
+ Misses       6921     6905      -16     
+ Partials     1137     1127      -10     
Flag Coverage Δ
unittests 75.55% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eefa27c...61ec74c. Read the comment docs.

@turbolent turbolent merged commit f228f65 into master Jun 10, 2021
@turbolent turbolent deleted the bastian/disable-wasmtime-vm branch June 10, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants