Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account docs to not to pass PublicKey as an argument #967

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Jun 2, 2021

Closes #965


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS added the Documentation Improvements or additions to documentation label Jun 2, 2021
@SupunS SupunS self-assigned this Jun 2, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #967 (f189fef) into master (d979afe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #967   +/-   ##
=======================================
  Coverage   75.43%   75.43%           
=======================================
  Files         268      268           
  Lines       32827    32827           
=======================================
  Hits        24762    24762           
  Misses       6929     6929           
  Partials     1136     1136           
Flag Coverage Δ
unittests 75.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d979afe...f189fef. Read the comment docs.

@SupunS SupunS merged commit d9d7b5f into master Jun 3, 2021
@SupunS SupunS deleted the supun/update-docs branch June 8, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The documentation incorrectly suggests you can pass an internal type to a transaction
4 participants