-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize qualified identifier creation #948
Conversation
4b28fde
to
ccc8742
Compare
This is a great optimization! This code is called often, so optimizing it makes a lot of sense 👍 |
Codecov Report
@@ Coverage Diff @@
## master #948 +/- ##
==========================================
+ Coverage 74.05% 74.08% +0.03%
==========================================
Files 269 269
Lines 33074 33089 +15
==========================================
+ Hits 24492 24515 +23
+ Misses 7453 7445 -8
Partials 1129 1129
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Description
A micro-optimization:
master
branchFiles changed
in the Github PR explorer