Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interpreter tests for common resource reference usages #916

Merged
merged 1 commit into from
May 18, 2021

Conversation

turbolent
Copy link
Member

Description

Add additional tests that I had written for an earlier fix where the result variable in post-conditions was changed to be a reference if the result type is a resource (#905).

The tests show that post-conditions existing on Mainnet keep working, i.e. ones that access members, and that use isInstance with a resource type.

This is a port of a part of dapperlabs/cadence-internal#9


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Merging #916 (4c892b3) into master (ca1e640) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #916   +/-   ##
=======================================
  Coverage   40.17%   40.17%           
=======================================
  Files         254      254           
  Lines       31882    31882           
=======================================
  Hits        12808    12808           
  Misses      18207    18207           
  Partials      867      867           
Flag Coverage Δ
unittests 40.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1e640...4c892b3. Read the comment docs.

@turbolent turbolent merged commit fcecfbf into master May 18, 2021
@turbolent turbolent deleted the bastian/reference-tests branch May 18, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants