Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI linter failure #904

Merged
merged 1 commit into from
May 14, 2021
Merged

Fix CI linter failure #904

merged 1 commit into from
May 14, 2021

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented May 14, 2021 •
edited
Loading

Description

Linter checks are failing probably due to a parallel merge of PRs (with the linter changes PR).

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS requested a review from turbolent as a code owner May 14, 2021 16:31
@SupunS SupunS self-assigned this May 14, 2021
@janezpodhostnik
Copy link
Contributor

these changes are also included in #903.

turbolent
turbolent approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@SupunS
Copy link
Member Author

SupunS commented May 14, 2021

ah yes. Maybe merging this one can unblock the other PRs

@SupunS SupunS merged commit 9333584 into master May 14, 2021
@SupunS SupunS deleted the supun/fix-lint branch May 14, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

Assignees

@SupunS SupunS

Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SupunS @janezpodhostnik @turbolent