Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Codecov "file not found at ./coverage.txt" #901

Merged
merged 1 commit into from
May 14, 2021

Conversation

fxamacker
Copy link
Member

Closes #900

Description

Change "cover.txt" to "coverage.txt" in Makefile.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Change "cover.txt" to "coverage.txt" in Makefile.

Closes #900
@fxamacker fxamacker added the Bug Something isn't working label May 13, 2021
@fxamacker fxamacker requested a review from turbolent as a code owner May 13, 2021 23:59
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ede5edf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #901   +/-   ##
=========================================
  Coverage          ?   39.85%           
=========================================
  Files             ?      254           
  Lines             ?    31521           
  Branches          ?        0           
=========================================
  Hits              ?    12562           
  Misses            ?    18120           
  Partials          ?      839           
Flag Coverage Δ
unittests 39.85% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede5edf...01ce584. Read the comment docs.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! 🙏

@fxamacker fxamacker merged commit 313495d into master May 14, 2021
@fxamacker fxamacker deleted the fxamacker/fix-codecov branch May 14, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Codecov "file not found at ./coverage.txt"
3 participants