Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-allocate and reuse value-path for decoding #869

Merged
merged 2 commits into from
May 3, 2021

Conversation

turbolent
Copy link
Member

Description

Just like in #858 for the encoder, pre-allocate the path and re-use it in the decoder.

Also, improve the naming a bit to avoid accidental confusion of the various "indices" that are declared and used for different purposes.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested review from SupunS and fxamacker May 3, 2021 23:41
@turbolent turbolent self-assigned this May 3, 2021
Copy link
Member

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@turbolent turbolent merged commit a3ab147 into master May 3, 2021
@turbolent turbolent deleted the bastian/optimize-decoding-path branch May 3, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants