Remove call to Valid() during encoding to boost speed by about 13-18% #857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #851
Description
Thanks @turbolent for suggesting this optimization last week.
Benchmark Comparisons
Speed improved by 13% to almost 18%. Memory use is unchanged.
Benchmarks used Go 1.15.11 on linux_amd64.
Caveats
Max limit for nested level is set to MaxInt16 because MaxInt32 would allow nested levels that would crash Go because of the 1 GB stack size limit of Go.
For contributor use:
master
branchFiles changed
in the Github PR explorer