Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update values-and-types.mdx #827

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Update values-and-types.mdx #827

merged 1 commit into from
Apr 22, 2021

Conversation

FeiyangTan
Copy link
Contributor

@FeiyangTan FeiyangTan commented Apr 22, 2021 •
edited by SupunS
Loading

just found that small mistake while reading the doc

Description

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@FeiyangTan
Update values-and-types.mdx
c3cc917 
just found that small mistake while reading the doc
SupunS
SupunS approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you for fixing this!

@joshuahannan joshuahannan merged commit a437402 into onflow:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuahannan joshuahannan joshuahannan approved these changes

@SupunS SupunS SupunS approved these changes

@turbolent turbolent Awaiting requested review from turbolent turbolent is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FeiyangTan @joshuahannan @SupunS