Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent cyclic imports #809

Merged
merged 4 commits into from
Apr 20, 2021
Merged

Prevent cyclic imports #809

merged 4 commits into from
Apr 20, 2021

Conversation

turbolent
Copy link
Member

Detect cyclic imports while checking and reject them.

In addition to the bugfix PR for v0.14.5, this PR also fixes error messages for cyclic imports, by pointing to the correct location.

Thanks to @SupunS for implementing the cycle detection 🙏

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Apr 19, 2021
SupunS
SupunS approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, @turbolent for sending a PR!

runtime/import_test.go Outdated Show resolved Hide resolved
runtime/repl.go Outdated Show resolved Hide resolved
turbolent and others added 2 commits April 20, 2021 10:19
@turbolent @SupunS
fix copyright year
1f884c0 
Co-authored-by: Supun Setunga <supun.setunga@gmail.com>
@turbolent @SupunS
remove unnecessary parameter name
b4e1227 
Co-authored-by: Supun Setunga <supun.setunga@gmail.com>
@turbolent turbolent merged commit bdb14f9 into master Apr 20, 2021
@turbolent turbolent deleted the bastian/prevent-cyclic-imports branch April 20, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee

Assignees

@turbolent turbolent

Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS