Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify function types #802

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Simplify function types #802

merged 2 commits into from
Apr 14, 2021

Conversation

turbolent
Copy link
Member

Description

  • Remove CheckedFunctionType wrapper, move functionality to FunctionType
  • Rename SpecialFunctionTypes to the more descriptive ConstructorFunctionType
  • Move the functionality of special function types to have members to FunctionType
  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent mentioned this pull request Apr 14, 2021
Merged
6 tasks
@turbolent turbolent self-assigned this Apr 14, 2021
SupunS
SupunS approved these changes Apr 14, 2021
View reviewed changes
runtime/sema/type.go Show resolved Hide resolved
@turbolent turbolent merged commit cc65a27 into master Apr 14, 2021
@turbolent turbolent deleted the bastian/simplify-function-types branch April 14, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@psiemens psiemens Awaiting requested review from psiemens

Assignees

@turbolent turbolent

Labels
Improvement Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS