Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve state decoding tool #798

Merged
merged 13 commits into from
Apr 16, 2021
Merged

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Apr 13, 2021

Closes #780

Description

Add two new flags:

  • old:
    Decode the data using the old decoder (v3)
  • roundtrip:
    After decoding, encode the data using the new encoder (v4), and decode it again.
    Ensure the equality of the originally decoded value, and the re-decoded value

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent
Copy link
Member Author

Also added a gzip flag for onflow/flow-go#627

@turbolent turbolent requested review from fxamacker and SupunS and removed request for SupunS April 16, 2021 22:01
Copy link
Member

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@turbolent
Copy link
Member Author

Thank you for having a look @fxamacker!

@turbolent turbolent merged commit b723c6f into master Apr 16, 2021
@turbolent turbolent deleted the bastian/improve-state-decoding-tool branch April 16, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Mainnet state is migratable
2 participants