Reject indirect incompatible updates to composite declarations #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #771
Description
Currently, doing incompatible changes to a composite type (like changing field types, adding new fields, etc) is not allowed. However, it is possible to remove an existing composite type, and add another composite type with the same name, but with a different structure, which has the same effect as doing an incompatible change.
This PR rejects such indirect changes to a struct. With this,
For contributor use:
master
branchFiles changed
in the Github PR explorer