-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add address field to capabilities #736
Add address field to capabilities #736
Conversation
So this isn't finished @turbolent - I'm having a weird issue with the test I wrote - `
} I'm getting this error - "global type 'addr' missing" even though it seems that I'm initializing it? Not sure exactly why this is happening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this!
Looks good, just the test needs to be fixed and then it can be merged
@ceelo777 Looks good, glad the test passes now. Just one last thing: Could you please add a test for the interpreter? |
To be honest, I'm not sure if I did this interpreter test correctly but it passed - anything else I should add to it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test looks good! 👍
Good idea to use the testAccount
helper.
One last thing would be to check the result values, then we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks again for adding this @ceelo777!
Closes #721
Description
This PR should add the ability to grab the address field from a capability.
For contributor use:
master
branchFiles changed
in the Github PR explorer