Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the syntax of the signature algorithm enum in docs #701

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Fix the syntax of the signature algorithm enum in docs #701

merged 1 commit into from
Mar 16, 2021

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Mar 16, 2021

Description

Fix the syntax of the signature algorithm enum in the crypto doc.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS added the Documentation Improvements or additions to documentation label Mar 16, 2021
@SupunS SupunS requested a review from turbolent March 16, 2021 19:14
turbolent
turbolent approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for fixing this 👍

@turbolent turbolent merged commit 9272737 into master Mar 16, 2021
@turbolent turbolent deleted the supun/fix-crypto-docs branch March 16, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@joshuahannan joshuahannan Awaiting requested review from joshuahannan

Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SupunS @turbolent