Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize interpreter: Evaluate statements and declarations directly, remove trampolines #684

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Optimize interpreter: Evaluate statements and declarations directly, remove trampolines #684

merged 3 commits into from
Mar 12, 2021

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Mar 10, 2021 •
edited
Loading

Closes #678

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Mar 10, 2021
@turbolent turbolent mentioned this pull request Mar 11, 2021
Merged
6 tasks
@turbolent turbolent force-pushed the bastian/optimize-interpreter-5 branch from 3070b78 to ec9b9ec Compare March 11, 2021 23:54
Base automatically changed from bastian/optimize-interpreter-5 to master March 12, 2021 00:01
@turbolent turbolent force-pushed the bastian/optimize-interpreter-6 branch from a25aeca to 2c1172e Compare March 12, 2021 00:06
SupunS
SupunS approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! 👏 👏 👏

runtime/interpreter/interpreter.go Outdated Show resolved Hide resolved
runtime/interpreter/interpreter.go Outdated Show resolved Hide resolved
@turbolent turbolent merged commit 24fef3a into master Mar 12, 2021
@turbolent turbolent deleted the bastian/optimize-interpreter-6 branch March 12, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

Assignees

@turbolent turbolent

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve interpreter performance
2 participants
@turbolent @SupunS