Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize interpreter activations #673

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

turbolent
Copy link
Member

Description

Use plain Go map for activations in interpreter and compiler. Only the checker needs activations with ordered maps.

  • Move activations with ordered map to checker
  • Change activations to use plain Go maps
  • Make activations generic (use genny)
  • Generate specialized activations for interpreter and compiler

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

- Move activations with ordered map to checker
- Change activations to use plain Go maps
- Make activations generic
- Generate specialized activations for interpreter and compiler
@turbolent turbolent force-pushed the bastian/optimize-interpreter-activations branch from 51a101c to 008a76a Compare March 12, 2021 19:58
@turbolent turbolent merged commit 5090901 into master Mar 15, 2021
@turbolent turbolent deleted the bastian/optimize-interpreter-activations branch March 15, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants