Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only record member accesses when origins and occurrences are enabled #627

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Only record member accesses when origins and occurrences are enabled #627

merged 2 commits into from
Feb 25, 2021

Conversation

turbolent
Copy link
Member

Description

In a past PR, recording origins and occurrences was made optional.
Also make recording member accesses optional.

In addition, only allocate the data structures necessary for recording origins and occurrences when it is enabled.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Feb 25, 2021
@turbolent turbolent merged commit 0a739a1 into master Feb 25, 2021
@turbolent turbolent deleted the bastian/disable-member-access-recording branch February 25, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

Assignees

@turbolent turbolent

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @janezpodhostnik