Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Any type, AnyResource type, and AnyStruct type to singleton #618

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Refactor Any type, AnyResource type, and AnyStruct type to singleton #618

merged 1 commit into from
Feb 24, 2021

Conversation

turbolent
Copy link
Member

⚠️ Depends on #617

Description

Reduce allocations by allocating only one instance for the Any, AnyStruct, and AnyResource types.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Feb 23, 2021
@turbolent turbolent changed the base branch from bastian/type-singletons to master February 24, 2021 17:27
@turbolent turbolent merged commit 26b1db1 into master Feb 24, 2021
@turbolent turbolent deleted the bastian/type-singletons-2 branch February 24, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

Assignees

@turbolent turbolent

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS