Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended debug #451
Extended debug #451
Changes from 1 commit
b1a313f
ca1a5ea
94cb9a3
4e3b597
1bb4e5d
6860e3e
85ee256
70d6c97
1f0f9c6
6e73f43
09b732b
9db3807
8aa50b0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite sure I understand this line, can you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this clarify cyclic imports enough? https://github.com/onflow/cadence/pull/451/files#diff-74ffa81b6938856f695ba112a721503dfc5ff2e852bc65d79d15ee4868f4bb97R4784-R4791
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are these used for debugging? The fields in
interpreterRuntimeStorage
are also not exported, so is exposing the storage here (and exportinginterpreterRuntimeStorage
asInterpreterRuntimeStorage
below) useful?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are dumped to a file for further usage. I didn't analyze what was particularly useful, just grabbed all there is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the runtime storage value doesn't provide any info, OK if I remove it?
Or we should maybe export the storage's cache, which could be useful to look at for execution errors.
Also, the functions that are injected are always the same, so IDK how useful it it is to include them in the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free if you think it doesn't provide any value, and add what you think it's best - you are the best person to know what internal elements might be helpful