Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language server command to get entry point parameters #406

Merged
merged 12 commits into from
Oct 13, 2020

Conversation

turbolent
Copy link
Member

Closes #405

  • Refactor the existing entry point analysis (transaction declaration or script function declaration) from the language server to the AST and sema. It could be useful in other tools, and having it in a central place ensures the assumptions won't get out of sync.
  • Add a function to sema which returns the parameters of the entry point
  • Add a command to the language server which returns the parameters of the entry point, leveraging the function in sema. This allow e.g. the VS Code extension and Playground, which use the language server, to request this information
  • Add a test suite for the language server
  • Add a test for the new command

Copy link
Member

@jordanschalm jordanschalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Nice work

languageserver/integration/diagnostics.go Outdated Show resolved Hide resolved
runtime/sema/entrypoint.go Outdated Show resolved Hide resolved
runtime/sema/entrypoint.go Outdated Show resolved Hide resolved
turbolent and others added 2 commits October 13, 2020 09:42
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
@turbolent turbolent merged commit bc1b226 into master Oct 13, 2020
@turbolent turbolent deleted the bastian/405-language-server-parameter-command branch October 13, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language Server: Add command to get transaction and script parameters
2 participants