Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm packages #382

Merged
merged 3 commits into from
Oct 13, 2020
Merged

npm packages #382

merged 3 commits into from
Oct 13, 2020

Conversation

turbolent
Copy link
Member

Add npm packages for the

  • language server
  • language client for the monaco editor
  • parser
  • demo for the language server
  • demo for the parser

Once merged, I'll publish cadence-language-server, monaco-languageclient-cadence, and cadence-parser on npm, and try to switch the Playground to use cadence-language-server and monaco-languageclient-cadence.

Also, cadence-parser will be useful for the Prettier plugin: It currently relies on the command line parser, with the WebAssembly-based package we can run the plugin in the browser. I plan to build a simple development tool like the Prettier Playground which will improve the development experience for the plugin.

cc @MaxStalker

add npm packages for the
- language server
- language client for the monaco editor
- parser
- demo for the language server
- demo for the parser
@turbolent
Copy link
Member Author

@psiemens @10thfloor Could someone please review this PR? It would be great to switch the Playground FE to use this instead of committing the binary to it

Copy link
Contributor

@psiemens psiemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@turbolent turbolent merged commit 8908080 into master Oct 13, 2020
@turbolent turbolent deleted the bastian/npm-packages branch October 13, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants