-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove account storage format V1 #3814
base: master
Are you sure you want to change the base?
Conversation
51dd11b
to
d10d916
Compare
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 61b9ab6 Collapsed results for better readability
|
d10d916
to
390d4fe
Compare
} | ||
|
||
// StorageFormatV2 is enabled. | ||
|
||
// Check if cached account format is available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we won't be able to remove the read of the domain register / V1 reads here, because that will produce a different execution result, i.e. require a HCU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for removing code related to storage format V1.
Since there are still register reads related to storage format V1, I opened an issue #3815 as a reminder for next HCU.
Follow-up to #3584
Description
Now that all production networks were migrated to storage format V2, we can remove format V1.
However, to avoid having to deploy this change in a HCU / avoid making this change produce a different execution result, we need to keep the existing logic / reads to determine the storage format.
If an account in format V1 is detected, abort execution with a new error.
master
branchFiles changed
in the Github PR explorer