Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow export and JSON encoding/decoding of type values and capabilities #374

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Sep 14, 2020

Closes #373

For now, just like for link values, encode the static type as a string.
A future PR may introduce support for exporting static types and encoding/decoding them, but for now that is not needed.

@turbolent turbolent self-assigned this Sep 14, 2020
@turbolent turbolent changed the title Allow export and JSON encoding/decoding of type values Allow export and JSON encoding/decoding of type values and capabilities Sep 15, 2020
Base automatically changed from bastian/318-allow-path-export- to master September 25, 2020 23:23
Copy link
Contributor

@tarakby tarakby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I only checked the syntax though, maybe someone else with Cadence experience should look at the logic.

Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@turbolent turbolent merged commit 8ea5185 into master Sep 28, 2020
@turbolent turbolent deleted the bastian/373-type-value-export branch September 28, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow saving of types and capabilities into contracts/resources in Playground
3 participants