Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify storage limits, enforce when encoding, fix bignum encoding #370

Merged
merged 12 commits into from
Sep 29, 2020
Merged

Specify storage limits, enforce when encoding, fix bignum encoding #370

merged 12 commits into from
Sep 29, 2020

Commits on Sep 10, 2020

  1. change the CBOR field keys to constants and use cbor.Tag directly ins… 

    …tead of registration
    @turbolent
    turbolent committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    384d189 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. switch to a fork of the CBOR library which exposes the validation fun… 

    …ction
    @turbolent
    turbolent committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    09923b0 View commit details
    Browse the repository at this point in the history

  2. explicitly specifiy the decoding options for CBOR decoding, bump limits

    @turbolent
    turbolent committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    2270020 View commit details
    Browse the repository at this point in the history

  3. fix encoding of negative bignums, bump version, support decoding of o… 

    …ld version

The encoding of negative bignums is specified in
https://tools.ietf.org/html/rfc7049#section-2.4.2:
"For tag value 3, the value of the bignum is -1 - n."

Negative bignums were encoded incorrectly in version < 2,
as just -n.

Fix this by adjusting by one.
    @turbolent
    turbolent committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    5ff72b7 View commit details
    Browse the repository at this point in the history

  4. try CI without cache

    @turbolent
    turbolent committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    dc49d49 View commit details
    Browse the repository at this point in the history

  5. Revert "try CI without cache" 

    This reverts commit dc49d49.
    @turbolent
    turbolent committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    3f2e97c View commit details
    Browse the repository at this point in the history

  6. also use the CBOR fork in the language server

    @turbolent
    turbolent committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    493e32f View commit details
    Browse the repository at this point in the history

  7. tidy

    @turbolent
    turbolent committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    24f4db8 View commit details
    Browse the repository at this point in the history

  8. remove ununesed CBOR tag constants

    @turbolent
    turbolent committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    587c240 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Improve comment for StripMagic 

    Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
    @turbolent @jordanschalm
    turbolent and jordanschalm authored Sep 29, 2020
    Configuration menu
    Copy the full SHA
    83e6374 View commit details
    Browse the repository at this point in the history

  2. Add comment for CBOR tags

    @turbolent
    turbolent authored Sep 29, 2020
    Configuration menu
    Copy the full SHA
    67dc79c View commit details
    Browse the repository at this point in the history

  3. Add explanation for negative bignum value

    @turbolent
    turbolent authored Sep 29, 2020
    Configuration menu
    Copy the full SHA
    f972fa9 View commit details
    Browse the repository at this point in the history