Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add struct as supported event parameter type #364

Merged
merged 4 commits into from
Sep 4, 2020
Merged

Add struct as supported event parameter type #364

merged 4 commits into from
Sep 4, 2020

Conversation

joshuahannan
Copy link
Member

@joshuahannan joshuahannan commented Sep 4, 2020 •
edited
Loading

Closes #313

Description

Allows structs to be used as event parameters as long as the fields are also valid event parameters

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent changed the title add struct as supported event parameter Add struct as supported event parameter type Sep 4, 2020
turbolent
turbolent approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍 Thank you!

@turbolent turbolent merged commit dfbee52 into master Sep 4, 2020
@turbolent turbolent deleted the josh/composite_args branch September 4, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@psiemens psiemens Awaiting requested review from psiemens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Composite Types (struct) as event parameters
2 participants
@joshuahannan @turbolent