Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Crypto contract on-chain #3619

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Oct 17, 2024

Closes #3135
Closes #1095

Description

Remove the Crypto contract from the Cadence codebase.

The contract will move to the https://github.com/onflow/flow-core-contracts repository.

FVM will need to provide the code by looking it up from a chain-specific account (likely, the service account).


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Oct 17, 2024
Copy link

github-actions bot commented Oct 17, 2024

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 0b1fc2b
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent marked this pull request as ready for review October 18, 2024 00:01
runtime/environment.go Outdated Show resolved Hide resolved
@turbolent
Copy link
Member Author

This is now ready to review @SupunS. onflow/flow-go#6571 shows how this will be integrated in flow-go, specifically https://github.com/onflow/flow-go/pull/6571/files#diff-10894ba9a96df76ec2d2c82e14b96a961ebb33dccd644e72d6752f490580a50eR96-R104

.github/workflows/ci.yml Show resolved Hide resolved
@turbolent turbolent merged commit df33ab8 into master Oct 18, 2024
8 of 12 checks passed
@turbolent turbolent deleted the bastian/3135-move-crypto-contract-onchain branch October 18, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the crypto contract outside of cadence Crypto.KeyList is not a storable type
2 participants