-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enums #344
Enums #344
Conversation
Nice PR :) |
_, err := checker.valueActivations.Declare(variableDeclaration{ | ||
identifier: declaration.Identifier.Identifier, | ||
ty: constructorType, | ||
// NOTE: enums are always public |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
assert.IsType(t, &sema.InvalidInterfaceDeclarationError{}, errs[0]) | ||
} | ||
|
||
func TestCheckInvalidEnumCaseDuplicate(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
320a6e4
to
8a749aa
Compare
Migrated the documentation. @joshuahannan could you please review the documentation update? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation looks good!
Yay! |
Closes #296
Fixes #361