Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enums #344

Merged
merged 25 commits into from
Sep 29, 2020
Merged

Enums #344

merged 25 commits into from
Sep 29, 2020

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Aug 23, 2020 •
edited
Loading

Closes #296
Fixes #361

@turbolent turbolent self-assigned this Aug 23, 2020
@turbolent turbolent added the Documentation Improvements or additions to documentation label Aug 24, 2020
@turbolent turbolent mentioned this pull request Aug 30, 2020
Closed
@bjartek
Copy link
Contributor

bjartek commented Sep 4, 2020

Nice PR :)

@turbolent turbolent removed the request for review from benjaminkvm September 13, 2020 19:35
zhangchiqing
zhangchiqing reviewed Sep 28, 2020
View reviewed changes
runtime/common/declarationkind_string.go Show resolved Hide resolved
runtime/parser2/declaration_test.go Outdated Show resolved Hide resolved
runtime/sema/check_composite_declaration.go Show resolved Hide resolved
runtime/sema/check_composite_declaration.go
_, err := checker.valueActivations.Declare(variableDeclaration{
identifier: declaration.Identifier.Identifier,
ty: constructorType,
// NOTE: enums are always public
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

runtime/parser2/declaration_test.go Show resolved Hide resolved
runtime/tests/checker/enum_test.go
assert.IsType(t, &sema.InvalidInterfaceDeclarationError{}, errs[0])
}

func TestCheckInvalidEnumCaseDuplicate(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

zhangchiqing
zhangchiqing approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@turbolent
Copy link
Member Author

Migrated the documentation. @joshuahannan could you please review the documentation update? Thank you!

joshuahannan
joshuahannan approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation looks good!

@turbolent turbolent merged commit 1b8090a into master Sep 29, 2020
@turbolent turbolent deleted the bastian/296-enums branch September 29, 2020 17:14
@bjartek
Copy link
Contributor

bjartek commented Sep 29, 2020

Yay!

@turbolent turbolent mentioned this pull request Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangchiqing zhangchiqing zhangchiqing approved these changes

@joshuahannan joshuahannan joshuahannan approved these changes

@psiemens psiemens Awaiting requested review from psiemens

@jordanschalm jordanschalm Awaiting requested review from jordanschalm

Assignees

@turbolent turbolent

Labels
Documentation Improvements or additions to documentation Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simple Hello World program panics Enums
4 participants
@turbolent @bjartek @zhangchiqing @joshuahannan