Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design pattern documentation to refer to the new Capability Bootstrapping API #2035

Merged
merged 6 commits into from
Oct 6, 2022

Conversation

dsainati1
Copy link
Contributor

@dsainati1 dsainati1 commented Oct 5, 2022

Depends on #1983


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

docs/design-patterns.mdx Outdated Show resolved Hide resolved
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please add a label

@dsainati1 dsainati1 added the Documentation Improvements or additions to documentation label Oct 6, 2022
@dsainati1 dsainati1 self-assigned this Oct 6, 2022
Base automatically changed from sainati/1951-publish-claim to master October 6, 2022 19:01
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 1db2320
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
InterpretRecursionFib-22.61ms ± 0%2.48ms ± 1%~(p=0.333 n=1+5)
NewInterpreter/new_interpreter-21.37µs ± 0%1.36µs ± 7%~(p=0.750 n=1+7)
NewInterpreter/new_sub-interpreter-2694ns ± 0%755ns ± 2%~(p=0.286 n=1+6)
ParseArray-29.29ms ± 0%9.34ms ± 8%~(p=0.750 n=1+7)
ParseDeploy/byte_array-213.3ms ± 0%13.9ms ± 2%~(p=0.286 n=1+6)
ParseDeploy/decode_hex-21.33ms ± 0%1.36ms ± 3%~(p=0.250 n=1+7)
ParseFungibleToken/With_memory_metering-2207µs ± 0%209µs ± 3%~(p=0.857 n=1+6)
ParseFungibleToken/Without_memory_metering-2163µs ± 0%167µs ± 3%~(p=0.750 n=1+7)
ParseInfix-27.41µs ± 0%7.85µs ± 2%~(p=0.286 n=1+6)
QualifiedIdentifierCreation/One_level-22.55ns ± 0%2.57ns ± 2%~(p=1.000 n=1+7)
QualifiedIdentifierCreation/Three_levels-2155ns ± 0%153ns ± 1%~(p=0.333 n=1+5)
RuntimeFungibleTokenTransfer-2774µs ± 0%626µs ±28%~(p=0.750 n=1+7)
RuntimeResourceDictionaryValues-25.65ms ± 0%5.83ms ± 6%~(p=0.750 n=1+7)
RuntimeScriptNoop-216.2µs ± 0%16.6µs ± 6%~(p=0.750 n=1+7)
ValueIsSubtypeOfSemaType-299.2ns ± 0%101.5ns ± 5%~(p=0.750 n=1+7)
 
alloc/opdelta
InterpretRecursionFib-21.00MB ± 0%1.00MB ± 0%−0.00%(p=0.000 n=1+7)
NewInterpreter/new_interpreter-2848B ± 0%848B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-2264B ± 0%264B ± 0%~(all equal)
ParseArray-22.75MB ± 0%2.73MB ± 7%~(p=0.750 n=1+7)
ParseDeploy/byte_array-24.30MB ± 0%4.19MB ± 3%~(p=1.000 n=1+7)
ParseDeploy/decode_hex-2214kB ± 0%214kB ± 0%~(p=1.000 n=1+7)
ParseFungibleToken/With_memory_metering-229.4kB ± 0%29.4kB ± 0%~(p=0.750 n=1+7)
ParseFungibleToken/Without_memory_metering-229.4kB ± 0%29.4kB ± 0%~(p=0.286 n=1+6)
ParseInfix-21.93kB ± 0%1.93kB ± 0%~(p=1.000 n=1+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
RuntimeFungibleTokenTransfer-2103kB ± 0%102kB ± 0%~(p=0.286 n=1+6)
RuntimeResourceDictionaryValues-22.27MB ± 0%2.27MB ± 0%~(p=0.500 n=1+7)
RuntimeScriptNoop-28.80kB ± 0%8.83kB ± 0%~(p=0.250 n=1+7)
ValueIsSubtypeOfSemaType-248.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
InterpretRecursionFib-218.9k ± 0%18.9k ± 0%~(all equal)
NewInterpreter/new_interpreter-214.0 ± 0%14.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-25.00 ± 0%5.00 ± 0%~(all equal)
ParseArray-269.6k ± 0%69.6k ± 0%~(p=1.250 n=1+7)
ParseDeploy/byte_array-2104k ± 0%104k ± 0%~(p=0.750 n=1+7)
ParseDeploy/decode_hex-275.0 ± 0%75.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-21.00k ± 0%1.00k ± 0%~(all equal)
ParseFungibleToken/Without_memory_metering-21.00k ± 0%1.00k ± 0%~(all equal)
ParseInfix-260.0 ± 0%60.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
RuntimeFungibleTokenTransfer-22.06k ± 0%2.06k ± 0%~(all equal)
RuntimeResourceDictionaryValues-236.9k ± 0%36.9k ± 0%~(p=1.500 n=1+7)
RuntimeScriptNoop-2145 ± 0%145 ± 0%~(all equal)
ValueIsSubtypeOfSemaType-21.00 ± 0%1.00 ± 0%~(all equal)
 

@dsainati1 dsainati1 merged commit 0c5d3e5 into master Oct 6, 2022
@dsainati1 dsainati1 deleted the sainati/capability-inbox-docs branch October 6, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants