-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBOR: Up MaxArrayElements, MaxNestedLevels decoding options #136
Conversation
// Maximum nested levels permitted. | ||
MaxNestedLevels: 256, | ||
// Maximum array elements permitted. | ||
MaxArrayElements: 134217728, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reasonable to say they'll never hit this limit i think :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually it'd be nice be able to instantiate a runtime like this:
rt := runtime.NewInterpreterRuntime(
runtime.WithEncoder(cborEncoderWithOptions),
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪 Thanks for the quick fix!
As discussed, would it be okay to only double the previous limits? @benjaminkvm @turbolent |
Replaced by #370 |
Description
Increase CBOR
DecOptions.MaxArrayElements
,DecOptions.MaxNestedLevels
decoder options (previously set at defaults 131072 and 32 respectively).Bug
While running a large test the following error was encountered while attempting to decode a large array from storage:
Testcase forthcoming, just wanted to put this out there in case it was urgent.